Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RM: remove url from GitRepo.__init__ -- was deprecated in 0.5.0 #5342

Merged
merged 2 commits into from Jan 20, 2021
Merged

RM: remove url from GitRepo.__init__ -- was deprecated in 0.5.0 #5342

merged 2 commits into from Jan 20, 2021

Conversation

yarikoptic
Copy link
Member

Note: no other uses of DeprecatedError exception ATM

@yarikoptic
RM: remove url from GitRepo.__init__ -- was deprecated in 0.5.0
990038a 
Note: no other uses of DeprecatedError exception ATM
kyleam
kyleam approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@kyleam kyleam left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, and I think it's probably safe to assume that nobody was relying on passing runner or anything beyond as a positional argument.

edit: ah, but the tests still aren't happy
edit2: perhaps fixed with the latest push, though there may be remaining issues

@kyleam
CLN: create: Don't call GitRepo and AnnexRepo with 'url'
2e4a5f5 
This deprecated argument was removed in the previous commit.
@kyleam
Copy link
Contributor

kyleam commented Jan 19, 2021

The remaining failure is the known test_parallel one from gh-5309.

https://ci.appveyor.com/project/mih/datalad/builds/37343210/job/i32hq1h5gfnhrmj5#L2095

mih
mih approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy to see that!

@mih mih merged commit fb323fb into datalad:master Jan 20, 2021
@yarikoptic yarikoptic deleted the rm-deprecated branch April 29, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mih mih mih approved these changes

@kyleam kyleam kyleam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yarikoptic @kyleam @mih